Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GHA configuration when using NRN as boilerplate (add owner/repo constants) #306

Open
Vadorequest opened this issue Apr 2, 2021 · 0 comments

Comments

@Vadorequest
Copy link
Member

Vadorequest commented Apr 2, 2021

Currently, it's not obvious/easy to know all the constants that needs to be replaced in the GHA workflow files.

For example:

[click to see logs](https://github.com/UnlyEd/next-right-now/pull/${{ steps.pr_id_finder.outputs.number }}/checks)

This would become [click to see logs](https://github.com/XXX/YYY/pull/${{ steps.pr_id_finder.outputs.number }}/checks)

We could define constants on top of each workflow file that'd be used instead of those unnamed constants, and that'd make it easier to replace them all at once in a breeze.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant