Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use box-drawing characters for character diagrams #1141

Closed
fredrik-bakke opened this issue May 21, 2024 · 0 comments
Closed

Use box-drawing characters for character diagrams #1141

fredrik-bakke opened this issue May 21, 2024 · 0 comments
Labels
enhancement New feature or request website

Comments

@fredrik-bakke
Copy link
Collaborator

fredrik-bakke commented May 21, 2024

I just realized this afternoon: why are we not using box-drawing characters for drawing our character diagrams? Agda-input: ---.

Here's a couple of rendered examples:

image
markdown
          B
      h  ∧| \  g
       /  |   \
     /  f | ⇑   ∨
    A ---------> C
    |     | hB   |
    | ⇗   ∨   ⇗  |
 hA |     B'     | hC
    | h' ∧  \ g' |
    |  /  ⇑   \  |
    ∨/          ∨∨
    A' --------> C'
          f'
          B
      h  ∧│ ╲  g
       ╱  │   ╲
     ╱  f │ ⇑   ∨
    A ─────────> C
    │     │ hB   │
    │ ⇗   ∨   ⇗  │
 hA │     B'     │ hC
    │ h' ∧  ╲ g' │
    │  ╱  ⇑   ╲  │
    ∨╱          ∨∨
    A' ────────> C'
          f'
       ∙
     ╱   ╲
    ╱     ╲
   ∨       ∨
  ∙ ──────> ∙

The first diagram is our current version of a commuting prism diagram, while the second diagram employs horizontal, vertical, and diagonal box-drawing characters. The third diagram demonstrates what the diagonals can look like with the right horizontal offset.

Note. It looks like there is a line spacing issue since the characters don't align perfectly, which they should by definition. This should also be fixed.

It seems to me that using box-drawing characters is objectively an improvement over our current convention, so I propose that we switch to using them. I am happy to back-implement this change if we agree it is better.

@fredrik-bakke fredrik-bakke added enhancement New feature or request website labels May 21, 2024
fredrik-bakke pushed a commit that referenced this issue Jun 6, 2024
- Renames and moves the "Formalized results from the literature"
- Fixes syntax highlighting of Agda flags in the `OPTIONS` pragma
- Fixes #1053 
- Improves line height for #1141
@fredrik-bakke fredrik-bakke closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant