You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Everything below was "auto-generated" by Better Code Hub, which raised this in the "Write Code Once" section of its report. I would probably move the definition of categories to be a static field in the Product class, so everyone can access it as Product.categories. Having two copies of his list is pretty risky; you'll have to modify both lists to keep things in sync.
This isn't necessary to keep BCH happy, but it's a pretty obvious thing that you probably want to fix.
I've selected for refactoring 17 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍
Here's the gist of this guideline:
Definition 📖
Do not copy code.
Why❓
When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
How 🔧
Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.
ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁
Good luck and happy coding! ✨ 💯
The text was updated successfully, but these errors were encountered:
Everything below was "auto-generated" by Better Code Hub, which raised this in the "Write Code Once" section of its report. I would probably move the definition of
categories
to be a static field in theProduct
class, so everyone can access it asProduct.categories
. Having two copies of his list is pretty risky; you'll have to modify both lists to keep things in sync.This isn't necessary to keep BCH happy, but it's a pretty obvious thing that you probably want to fix.
I've selected for refactoring 17 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍
Here's the gist of this guideline:
Do not copy code.
When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.
You can find more info about this guideline in Building Maintainable Software. 📖
ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁
Good luck and happy coding! ✨ 💯
The text was updated successfully, but these errors were encountered: