Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 17 lines occurring 2 times in 2 files: pantry-products-list.component.ts, product-list.component.ts #39

Open
NicMcPhee opened this issue Apr 18, 2022 · 0 comments

Comments

@NicMcPhee
Copy link
Contributor

Everything below was "auto-generated" by Better Code Hub, which raised this in the "Write Code Once" section of its report. I would probably move the definition of categories to be a static field in the Product class, so everyone can access it as Product.categories. Having two copies of his list is pretty risky; you'll have to modify both lists to keep things in sync.

This isn't necessary to keep BCH happy, but it's a pretty obvious thing that you probably want to fix.


I've selected for refactoring 17 lines of code which are duplicated in 2 file(s) (1, 2). Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Code Once guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Do not copy code.
  • Why
    When code is copied, bugs need to be fixed in multiple places. This is both inefficient and a source of regression bugs.
  • How 🔧
    Avoid duplication by never copy/pasting blocks of code and reduce duplication by extracting shared code, either to a new unit or introduce a superclass if the language permits.

You can find more info about this guideline in Building Maintainable Software. 📖


ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁


Good luck and happy coding! :shipit: ✨ 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant