-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Thumbnails don't load if their path contains a "%" character #1117
Comments
Of course, if you download a single video and put a custom output name which doesn't have any "%" in it, everything work fine, but you can't always do that with subscriptions. |
Kramoule
added a commit
to Kramoule/YoutubeDL-Material
that referenced
this issue
May 18, 2024
This step is already done by the Express framework. (cf. https://expressjs.com/en/4x/api.html#req.params) fix Tzahi12345#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Thumbnails don't load if their filename contains a "%" character.
I have also investigated the issue.
The docker logs are:
The error apparently comes when it's trying to decode the URI path parameter.
YoutubeDL-Material/backend/app.js
Lines 1620 to 1621 in 58f4313
But the Express documentation says that req.params is already decoded:
(Source: https://expressjs.com/en/4x/api.html#req.params)
So the backend here is actually trying to decode an already valid filepath.
For example with a filepath
audio/100%Bug.webp
:decodeURIComponent("audio/100%Bug.webp")
will return an error.A solution is to simply remove the
decodeURIComponent
function if it served no purpose.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Your files should display the thumbnail, as usual.
Screenshots
Environment
The text was updated successfully, but these errors were encountered: