Replies: 16 comments 32 replies
-
|
There is no more webpack example, I think this is an issue since webpack is still the more widely used bundler
I think it's a good idea, but it'll complexify the debugging (since the code will be transformed/bundled). Won't having 2 versions be confusing? Another solution, with a bigger refactor, can be to create a new |
Beta Was this translation helpful? Give feedback.
-
On the long run this likely the better solution. On branch
Yes, true, maybe we should add a second build/execution path for the client example |
Beta Was this translation helpful? Give feedback.
-
|
If we could solve the whole vscode-compatibility problem just on a dependency level, then users don't have to fiddle with bundlers |
Beta Was this translation helpful? Give feedback.
-
|
FYI, Just released |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr when is a good time to switch from |
Beta Was this translation helpful? Give feedback.
-
|
Now seems to be a pretty good time, the main pain when switch the main branch are the currently open PRs, and there is none.
I don't know, I'm not even sure it needs to be communicated specifically. A sentence in the README can't hurt |
Beta Was this translation helpful? Give feedback.
-
|
Done! I switch the protection rule along. Shall I delete the |
Beta Was this translation helpful? Give feedback.
-
|
I do think so, along with all other temp branches (and add the rule that delete PR branches when merged?) |
Beta Was this translation helpful? Give feedback.
-
Adjusted configuration, let's see if it works as expected with next PR |
Beta Was this translation helpful? Give feedback.
-
|
Can you please publish a version including the last changes? |
Beta Was this translation helpful? Give feedback.
-
|
#342 in particular |
Beta Was this translation helpful? Give feedback.
-
|
0.19.0-next.1 includes that already |
Beta Was this translation helpful? Give feedback.
-
|
Oh you're right, sorry, I forgot about the path change |
Beta Was this translation helpful? Give feedback.
-
|
I haven't done much here the last two to three weeks. I want to bring the webpack example back and merge your latest PR. Then we should release a new official version. |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr I have pushed the release preparation on main, but a I see error message coming up in the log when hitting code completion. Do you have a quick idea? |
Beta Was this translation helpful? Give feedback.
-
|
Since it just breaks the example and not the client, is it mandatory to fix it before the release? |
Beta Was this translation helpful? Give feedback.
-
|
The problem resides from vite not properly reloading the commonjs package (client lib). This should work with the configuratrion applied, but it doesn't. The code is not ESM compatible and therefore cannot be loaded as module (we should change that on the long run IMO, but not now).
I will now release 1.0.0. Any objections? |
Beta Was this translation helpful? Give feedback.
-
|
Not the slightest one :) |
Beta Was this translation helpful? Give feedback.
-
|
And I repeat to myself never release on Friday 😆 |
Beta Was this translation helpful? Give feedback.
-
|
You're only releasing a library, people just have to not include and release their app today :) |
Beta Was this translation helpful? Give feedback.
-
|
I closed the "get everything going again" issue and created a couple of enhancement issues that we can discuss. |
Beta Was this translation helpful? Give feedback.
-
|
Should we clear-up the |
Beta Was this translation helpful? Give feedback.
-
|
I don't think there is any point of having inactive users in this file as it's mainly used to set the PRs reviewers, isn't it? |
Beta Was this translation helpful? Give feedback.
-
Yes, exactly. |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr I think your ingenious ideas that lead |
Beta Was this translation helpful? Give feedback.
-
|
I think #363 can be closed as the issue can no longer be observed with 2.0.0+ |
Beta Was this translation helpful? Give feedback.
-
|
You're right, I see no reason to use monaco-editor-core, but I don't see any reason to not provide the workaround That being said, there is the same issue with every lib using monaco-editor |
Beta Was this translation helpful? Give feedback.
-
Now, you confused me. That means "yes, we add a workaround description", right? 🙂 |
Beta Was this translation helpful? Give feedback.
-
|
Yep! |
Beta Was this translation helpful? Give feedback.
-
|
I used howfat to print the dependency tree |
Beta Was this translation helpful? Give feedback.
-
|
Are you sure howfat support dependency aliases? What is telling |
Beta Was this translation helpful? Give feedback.
-
|
Yes, you are right. Nevermind, it is a tool problem. I will use |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr FYI I am on vacation the next two weeks and my activity will be very limited here and response times will likely be bad. C ya 👋 |
Beta Was this translation helpful? Give feedback.
-
|
No problem, enjoy your vacation! 🍹 |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr I have closed multiple stale / outdated / issues or issues that were actually questions. Will release 4.0.1 soon. |
Beta Was this translation helpful? Give feedback.
-
|
@CGNonofr Good job |
Beta Was this translation helpful? Give feedback.
-
|
Nice! how do you explain it? |
Beta Was this translation helpful? Give feedback.
-
|
And what about the drop starting from mid-2021? |
Beta Was this translation helpful? Give feedback.
-
|
The step rise, I don't really know. There is no smoking gun. Maybe, some of the packages using it got more popular or updated their CI pipeline 🙈 🙂 https://github.com/TypeFox/monaco-languageclient/network/dependents?dependent_type=PACKAGE |
Beta Was this translation helpful? Give feedback.
-
Us not releasing new versions!? You created the codingame packge. 2022: us working together! 🎉 |
Beta Was this translation helpful? Give feedback.
-
Let's use this to exchange ideas and leave notes
vscode-compatibilityand all imported code and add them as separate exports to the package.json?monaco-vscode-apipackage), then users don't have to fiddle with bundlersmastertomainbranch ✅Beta Was this translation helpful? Give feedback.
All reactions