Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover misdetects when partial and helper are on the same line #14

Open
royalfig opened this issue Sep 21, 2022 · 0 comments
Open

Hover misdetects when partial and helper are on the same line #14

royalfig opened this issue Sep 21, 2022 · 0 comments

Comments

@royalfig
Copy link
Contributor

royalfig commented Sep 21, 2022

<a class="gh-social-link gh-social-facebook" href="{{facebook_url @site.facebook}}" title="Facebook" target="_blank" rel="me noopener">{{> "icons/facebook"}}</a>

Default word detection provided by VS Code's API, uses a simple regex to isolate words. This works for most cases, where {{facebook}} is recognized as facebook. However, for something like a partial, the syntax of which relies on non-word characters, detection is more problematic.

The current custom resolver fails when a helper and partial are on the same line.

Solutions:

  • Write more advanced custom resolvers
  • Remove the default word regex and use a custom one
  • Look into using the Language Extensions API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant