Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HuggingFace Object Detection Estimators #2383

Open
f4str opened this issue Jan 9, 2024 · 0 comments
Open

Implement HuggingFace Object Detection Estimators #2383

f4str opened this issue Jan 9, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@f4str
Copy link
Collaborator

f4str commented Jan 9, 2024

Is your feature request related to a problem? Please describe.
Previously, the HuggingFaceClassifierPyTorch was implemented for the classification task. A similar estimator should be implemented for the object detection task. This will allow usage of HuggingFace object detection models like YOLOS, YOLOP, and DETR.

Describe the solution you'd like
A new estimator named HuggingFaceObjectDetector should be implemented under art.estimators.object_detection. The estimator will subclass the PyTorchObjectDetector since it should use the same functionality. It will be structured in a similar way to the HuggingFaceClassifierPyTorch where it takes in the HuggingFace model and preprocessor.

Describe alternatives you've considered
There is consideration whether to call the estimator HuggingFaceObjectDetector or HuggingFaceObjectDetectorPyTorch. Ultimately it is better to use HuggingFaceObjectDetector since most HuggingFace models are PyTorch-based and this name is more concise.

Additional context
This issue will be addressed after #2267 is resolved since it depends on the rebase.

@beat-buesser beat-buesser added the enhancement New feature or request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants