Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/arnav710/add delete admin flow #152

Closed
wants to merge 50 commits into from

Conversation

PiXlRAM
Copy link
Member

@PiXlRAM PiXlRAM commented May 20, 2023

Adminstrative Info

Closes #104

Changes

Added add and delete admin pages, and created component for pop-up box that appears once add or delete buttons clicked.

Confirmation of Change

image

image

Arnav710 and others added 30 commits February 5, 2023 22:09
- Added an options interface to define each option in the dropdown
-  Made changes to select all so that the select all opertaion could be performed in multiple tabs at the same time
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment here on the page structuring:
So in Next, files under pages will be automatically routed to. However, we'd rather have the structure of these pages to be /admin, /admin/add, /admin/delete from a routing perspective. To do this, we can move all the files under a folder in pages named admin, and rename admin.tsx to index.tsx, add-admin.tsx to add.tsx, and delete-admin.tsx to delete.tsx

AdminPortal/src/pages/admin.tsx Outdated Show resolved Hide resolved
AdminPortal/src/pages/dashboard.tsx Outdated Show resolved Hide resolved
AdminPortal/src/styles/Dashboard.module.css Outdated Show resolved Hide resolved
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments about file stucture for pages "/admin/add", "/admin/delete", "/admin/index.tsx", etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Portal - Add/Delete Admin Flow
3 participants