-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a delay before analysing URLs #356
Comments
There is in fact special logic that marks some url changes (currently used only by the input text module) as "modifications of the previous url". But I think only the history module uses it to "replace" the previous url with that one. You can easily test this by editing a url (writing or deleting characters quickly) and checking the history list (middle "clock" button). Only the last url will appear. The issue with this approach is that, since it is a "modify the past" approach, modules in general can't react to it (they don't know if there will be a next input or not) so I also agree that replacing it with a "only send modifications after a small period of inactivity" should be done. As for your suggestions, the button approach could work perfectly with #100, and I'm not sure now how to detect the keyboard hiding, but detecting focus out of the textbox should be perfectly possible. Detecting a line break is a bit more problematic (what if the original text has one?) but you should be able to detect the "apply" keyboard button easily instead. |
Problem
When typing in the URL textbox, the URL view updates every time a character was typed.
This would lead to problems such as the log file and the history list is too long, or performance issues especially when a bunch of characters got deleted by pressing the Backspace key (instead of select and delete), which is common among mobile device users.
Suggestion
We can add a delay feature to the textbox, which let the application to wait for a while (maybe around 0.5 seconds) to let users complete their changes before analysing the URL and adding it to the log and history.
Alternative
We can also use an event to trigger the update of the view, such as:
Acknowledgements
The text was updated successfully, but these errors were encountered: