Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open links in some applications #325

Open
3 tasks done
sojuo opened this issue Mar 9, 2024 · 8 comments
Open
3 tasks done

Can't open links in some applications #325

sojuo opened this issue Mar 9, 2024 · 8 comments
Labels
bug Something isn't working question Further information is requested

Comments

@sojuo
Copy link

sojuo commented Mar 9, 2024

Steps to reproduce

Use URLChecker open some links which is like www.bilibili.com m.bilibili.com bilibili.com or others.

Expected behavior

Users should be able to choose any application that can open links to open them, especially those applications that themselves support opening links by default.

Actual behavior

I can't open *bilibili.com with PipePipe which supports default opening of *.bilibili.com.
A similar situation exists with other links and applications.

URLCheck version

2.13.1

Android version

Android 12

Android Custom/Specific ROM or Device

MIUI 13.0.7

Other details

ResizedImage_2024-03-09_20-45-56_1213
Screenshot_2024-03-09-20-44-59-287-edit_com trianguloy urlchecker
Screenshot_2024-03-09-20-44-46-407-edit_com trianguloy urlchecker
Screenshot_2024-03-09-20-40-53-959-edit_com android settings

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@sojuo sojuo added the bug Something isn't working label Mar 9, 2024
@TrianguloY
Copy link
Owner

Which exact url are you trying to open? Does it opens from the browser?

The intent filter that pipepipe has is defined here and it must:

  • Be http or https
  • Contain as suffix the substring ".bilibili.com"
  • Contain as path prefix any of "/video/" or "/bangumi/play/" or "/space/"

This means that, for example, these links are valid:

But these, for example, aren't

I've tested them on a device and it works as expected.

The list of apps is directly managed by android itself (except for the auto-removal of the referrer and rejected, which you can disable from the open module settings if needed). Some apps can also be missing if you have configured android to not show them.
In general, if a browser can open a link, my app will too. If you can find a link that doesn't, please tell me and I'll fix it, but if not I'll close this issue as it is working as expected.

@TrianguloY TrianguloY added the question Further information is requested label Mar 11, 2024
@franco27
Copy link

Me too. I have several apps that don't work properly because normally the links open inside those apps. You should be able to add in the settings of your application, the applications to be ignored or have a "disable" button

@TrianguloY
Copy link
Owner

@franco27 that's a different issue (similar to #303 ) and I think I fixed that and will be available on the next version (but you can test the evaluation version on the translation pr).

This issue is for apps not appearing on the list of available apps.

@pressRtowin
Copy link

@TrianguloY, I'm glad I decided to take a peak at the recent issues here, because in testing for LinkSheet/LinkSheet#349, I noticed that URLCheck (and actually just about every other similar app, including Better Open With and Open Link With) was also affected. I wonder if this is also the cause of #196, which I reported a while back.

LinkSheet's developer seems to have found a fix however, as Amazon does appear in LinkSheet now, but the fix—as of now—also breaks some other things.

@TrianguloY
Copy link
Owner

Issue #196 is due to the "wrong" code I'm using to detect the available actions. I know of a better one (maybe even several) but I haven't spent time yet to properly implement it. The current code mostly works, except for apps with multiple activities.

I don't know if this could fix the issue (most probably won't) but I'll try to remember to check it.

Btw: I read your post linked and I'll admit that behavior is really really strange. Android is making less sense with each update 🤔

@pressRtowin
Copy link

Issue #196 is due to the "wrong" code I'm using to detect the available actions. I know of a better one (maybe even several) but I haven't spent time yet to properly implement it. The current code mostly works, except for apps with multiple activities.

I don't know if this could fix the issue (most probably won't) but I'll try to remember to check it.

Btw: I read your post linked and I'll admit that behavior is really really strange. Android is making less sense with each update 🤔

Yeah it seems like this is a different issue after all. I misinterpreted what was being discussed above with how verified links for that app are being listed.

Should I open a new issue for the case of apps disappearing from URLCheck when their auto link opening is turned off in system settings? I don't think one exists yet. Also, fwiw, LinkSheet seems to have fixed the bug entirely now, with no negative side-effects, so you may find some insight in the recent commits on the issue I linked above.

@TrianguloY
Copy link
Owner

TrianguloY commented Mar 20, 2024

Should I open a new issue for the case of apps disappearing from URLCheck when their auto link opening is turned off in system settings? I don't think one exists yet. Also, fwiw, LinkSheet seems to have fixed the bug entirely now, with no negative side-effects, so you may find some insight in the recent commits on the issue I linked above.

Sure! It may help to log related comments and possible solutions.
I've quickly looked at the related commits but I think the important one is the first, I'll try to understand what is being made exactly, in case I can implement something (although I want to try some other things first)

@pressRtowin
Copy link

#332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants