Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't exit when Dev Tools is opened #12

Open
GreepTheSheep opened this issue Oct 6, 2020 · 5 comments
Open

Won't exit when Dev Tools is opened #12

GreepTheSheep opened this issue Oct 6, 2020 · 5 comments
Assignees
Labels
question Further information is requested

Comments

@GreepTheSheep
Copy link

Describe the bug
When BrowserWindow Dev Tools is opened, the BrowserWindow won't exit when click on close

To Reproduce
Steps to reproduce the behavior:

  1. Start the window with Dev Tools opened
  2. Click on exit button

Expected behavior
Window normally closes

Desktop (please complete the following information):

  • OS: Windows 10 1909
  • Electron version 10.1.0
  • Node Version 12.16.3
@DanielMcAssey
Copy link

+1 also noticed this

@GreepTheSheep
Copy link
Author

Maybe that's not from the module, but from electron, I haven't tested with an HTML input that call close()

@Treverix
Copy link
Owner

Treverix commented Oct 6, 2020

I've reported that issue for electron back in august and they consider it as an electron bug that is not yet resolved.

electron/electron#25012

@GreepTheSheep , @DanielMcAssey - could you check over there if it fails for the same reasons on you side or if you have different conditions?

@Treverix Treverix self-assigned this Oct 6, 2020
@Treverix Treverix added the question Further information is requested label Oct 6, 2020
@DanielMcAssey
Copy link

I will try it now, however mine isnt detached. I have mine docked to the right of the window and I still cant close it.

@Treverix
Copy link
Owner

Treverix commented Oct 6, 2020

The devtools mode was not the problem - it was more related to frameless windows (frame: false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants