Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency Issue] Isomorphic-unfetch: invalid path for export in package.json #95

Open
alinasir85 opened this issue Oct 24, 2023 · 3 comments

Comments

@alinasir85
Copy link

Hi,

There's an export issue in unfetch version 5 which is mentioned in below PR but its not merged since February 2023

developit/unfetch#164

Toucan-sdk is using "isomorphic-unfetch": "^4.0.2" which internally using unfetch version 5 thus causing below issue while bundling:

**✘ [ERROR] Could not resolve "unfetch"

../../../../fireblocks/node_modules/isomorphic-unfetch/index.js:7:14:
  7 │     ? r(require("unfetch"))
    ╵                 ~~~~~~~~~

The module "./index.js" was not found on the file system:
../../../../fireblocks/node_modules/unfetch/package.json:19:17:
19 │ "default": "./index.js"
╵ ~~~~~~~~~~~~
You can mark the path "unfetch" as external to exclude it from the bundle, which will remove this
error. You can also surround this "require" call with a try/catch block to handle this failure at
run-time instead of bundle-time.**

Kindly fix it using alternative library or downgrade isomorphic-unfetch to 4.0.0 which solves the issue until PR gets merged

@aspiers
Copy link
Member

aspiers commented Nov 14, 2023

Thanks a lot for the report, I have filed an internal ticket to track this (currently only visible by team members - apologies for that).

To clarify, is this breaking installation of the SDK for you, or just certain functionality? Thanks again!

@alinasir85
Copy link
Author

Package is not able to build/bundle due to "unfetch" dependency not being resolved in the latest version.
Had to use version "1.0.0-beta" of toucan-sdk which uses older version of "unfetch" library, hence solving issue

@pheuberger
Copy link
Contributor

@alinasir85 which bundler are you using so I can test the behavior?

pheuberger added a commit to pheuberger/toucan-sdk that referenced this issue Nov 29, 2023
Without this patch people were experiencing problems when bundling the
SDK. See issue ToucanProtocol#95 ToucanProtocol#95

The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch`
5.0.0 which currently has an issue with their module exports leading to
an error when bundling the lib itself or any other lib that depends on
`unfetch`.

See this PR for more information: developit/unfetch#164

Once this PR is merged we can go back to the latest `isomorphic-unfetch`
version.
pheuberger added a commit to pheuberger/toucan-sdk that referenced this issue Nov 29, 2023
Without this patch people were experiencing problems when bundling the
SDK. See issue ToucanProtocol#95 ToucanProtocol#95

The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch`
5.0.0 which currently has an issue with their module exports leading to
an error when bundling the lib itself or any other lib that depends on
`unfetch`.

See this PR for more information: developit/unfetch#164

Once the PR above is merged we can go back to the latest `isomorphic-unfetch`
version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants