Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Adapter trait with optional async #5

Open
Totodore opened this issue May 24, 2023 · 3 comments
Open

Feature: Adapter trait with optional async #5

Totodore opened this issue May 24, 2023 · 3 comments
Assignees
@Totodore
Labels
enhancement New feature or request refactoring This reference a need for a refactoring socketio-v4 It is only about the version 4 of the socket.io protocol socketio-v5 It is only about the version 5 of the socket.io protocol

Comments

@Totodore
Copy link
Owner

Make a version of the adapter trait async. This will allow remote adapter implementation (e.g redis adapter, mongodb adapter).
@Totodore Totodore added the enhancement New feature or request label May 24, 2023
@Shorakie
Copy link

does the maybe_async crate cut it?

@Totodore
Copy link
Owner Author

Yes, it is a good idea, but it implies to also apply maybe_async on Operators and Socket structs to maybe return futures from the adapter.

@Totodore Totodore mentioned this issue Oct 2, 2023
Open
@Totodore Totodore added help wanted Extra attention is needed refactoring This reference a need for a refactoring labels Nov 23, 2023
@Totodore Totodore added socketio-v4 It is only about the version 4 of the socket.io protocol socketio-v5 It is only about the version 5 of the socket.io protocol labels Dec 15, 2023
@Totodore Totodore self-assigned this Dec 20, 2023
@Totodore Totodore removed the help wanted Extra attention is needed label Dec 20, 2023
@ElijahJohnson5
Copy link

This would be awesome to have! Really enjoy the work you are doing on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Totodore Totodore

Labels
enhancement New feature or request refactoring This reference a need for a refactoring socketio-v4 It is only about the version 4 of the socket.io protocol socketio-v5 It is only about the version 5 of the socket.io protocol
Projects
Roadmap
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ElijahJohnson5 @Shorakie @Totodore