Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional data sources by default #15

Open
1 of 2 tasks
Torvaney opened this issue Apr 8, 2020 · 2 comments
Open
1 of 2 tasks

Additional data sources by default #15

Torvaney opened this issue Apr 8, 2020 · 2 comments
Assignees

Comments

@Torvaney
Copy link
Owner

Torvaney commented Apr 8, 2020

  • Tracab
  • Metrica
@Torvaney Torvaney self-assigned this Apr 8, 2020
@Torvaney Torvaney changed the title Additional data sources Additional data sources by default Apr 8, 2020
@huffyhenry
Copy link
Contributor

Tracab uses centimetres and not synthetic units. The actual pitch length and width are specified in the metadata. The other dimensions (penalty box width, etc.) are not provided. And to confuse the matters further, Tracab files are in my experience often distributed without metadata.

In light of this, it seems to me that support for Tracab should be a method that constructs pitch_tracab from width and length (with the usual 105x68 defaults). The missing dimensions should be probably taken from the standard pitch? Goal sizes certainly are fixed, and getting the rest correct is simply impossible without extra information.

In summary, I propose this design:

make_pitch_tracab <- function(length=105, width=68){
    list(
        length=100.0*length,
        width=100.0*width,
        origin_x=-50.0*length,
        origin_y=-50.0*width,
        goal_width=732.0,
        ...
    )
}

pitch_tracab <- make_pitch_tracab()

If this makes sense to you, I can send a PR in the next few days.

@Torvaney
Copy link
Owner Author

Yep - that sounds fantastic!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants