Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dark mode] fix color of time selection box in datepicker #6271

Open
withshubh opened this issue May 5, 2023 · 21 comments
Open

[dark mode] fix color of time selection box in datepicker #6271

withshubh opened this issue May 5, 2023 · 21 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@withshubh
Copy link
Contributor

What is the current behaviour?

In dark mode, the color of the time selection box in datepicker should be dark.

How to reproduce the issue?

  1. Switch to dark mode
  2. drag a datepicker
  3. enable time selection from datepicker property
  4. Check the color of the Time selection box

Screenshots or Screencast

Screenshot 2023-05-05 at 6 00 14 PM

@withshubh withshubh added bug Something isn't working good first issue Good for newcomers up-for-grabs labels May 5, 2023
@wxomi
Copy link

wxomi commented May 5, 2023

I would like to work on this issue

@JayeshJanyani
Copy link

I too can work on this.

@Sheikh-JamirAlam
Copy link
Contributor

The selection items are all white background. Should be make dark themed.

image

@PrasannaBH
Copy link

Hey, i would like to work on this issue

@Sheikh-JamirAlam
Copy link
Contributor

@withshubh Came up with this. Unfornately I don't think it is possible to edit the color for the clock icon in the time section.
image

@PrasannaBH
Copy link

@withshubh @Sheikh-JamirAlam
i pulled the latest code and made changes but i cant see the the clock image that is present in your screenshot

Screenshot from 2023-05-06 23-38-03

@Sheikh-JamirAlam
Copy link
Contributor

@PrasannaBH That's weird. I also pulled the latest repo only.

@withshubh
Copy link
Contributor Author

Hey @wxomi - Thanks for showing interest in contributing to ToolJet. Assigned the issue to you.

@PrasannaBH
Copy link

PrasannaBH commented May 20, 2023

@PrasannaBH That's weird. I also pulled the latest repo only.

@Sheikh-JamirAlam Which branch are you using ? I am using the develop branch

@PrasannaBH
Copy link

Hey @withshubh can you please assign this to me nobody is working. I can make PR for this issue

@withshubh
Copy link
Contributor Author

Hey @wxomi - Any updates on the PR?

@iSatVeerSingh
Copy link
Contributor

@withshubh Please assign me.

@wxomi wxomi removed their assignment Jun 4, 2023
@withshubh
Copy link
Contributor Author

Hi @JayeshJanyani - Are you still interested in picking up this issue?

@JayeshJanyani
Copy link

@withshubh Sure

@withshubh
Copy link
Contributor Author

@JayeshJanyani - Thanks for showing interest. Assigned to you.

@withshubh
Copy link
Contributor Author

Hey @JayeshJanyani - Any updates on the PR?

@JayeshJanyani
Copy link

Hey @JayeshJanyani - Any updates on the PR?

@withshubh Can you please assign it to someone else, as I am a bit occupied with another issue.
Thanks in advance.

@iSatVeerSingh
Copy link
Contributor

@withshubh Can you please check my PR?

@atharvnaik1
Copy link

@karan-rathod-316 Please assign me if its still open .

@karan-rathod-316
Copy link
Collaborator

Hi @atharvnaik1,

Assigning this to you. Happy coding:-)

@atharvnaik1
Copy link

atharvnaik1 commented May 1, 2024

Implemented changes in theme.scss and respective files input.react-datepicker-time__input background color from white to dark mode.
Updated the time popper for dark theme.
#9581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants