Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VC limit for each dungeon on a per-section basis. #214

Open
ewang2002 opened this issue Jul 22, 2022 · 0 comments
Open

Add VC limit for each dungeon on a per-section basis. #214

ewang2002 opened this issue Jul 22, 2022 · 0 comments
Labels
c-config Category: Configuration-related (all configuration commands) it-enhancement Issue Type: Enhancement (new feature or request)

Comments

@ewang2002
Copy link
Member

One easy way to implement this is to have an array for each section (including the main section) where each element is of type

interface IDungeonLimit { 
    dungeonId: string; // the dungeon unique identifier
    vcLimit: number; // the VC limit
}

Then, to get the VC limit, we can do the following:

  • check if there is a defined VC limit for that dungeon in the section
  • if not, fallback to the default section VC limit

We can potentially extend this to include the ability to

  • customize number of people that can get Nitro (right now, you can only customize it on a per-dungeon basis, not on a per-dungeon+section basis)
  • customize number of people that can use Points to get in (same idea as above)
  • customize number of Points needed to get in (same idea as above)
@ewang2002 ewang2002 added it-enhancement Issue Type: Enhancement (new feature or request) c-config Category: Configuration-related (all configuration commands) labels Jul 22, 2022
@ewang2002 ewang2002 linked a pull request Aug 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-config Category: Configuration-related (all configuration commands) it-enhancement Issue Type: Enhancement (new feature or request)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant