Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discord.js v14 migration #208

Open
ewang2002 opened this issue Jul 19, 2022 · 1 comment
Open

discord.js v14 migration #208

ewang2002 opened this issue Jul 19, 2022 · 1 comment
Labels
c-internal Category: Internal implementation (e.g., library changes) it-bug Issue Type: Bug report it-enhancement Issue Type: Enhancement (new feature or request)

Comments

@ewang2002
Copy link
Member

discord.js released v14 a few days ago. If possible, I'd like to update Tooga to the latest version of discord.js. Regarding the release itself, one of the main things I'm interested in is the use of modals to better facilitate user input -- I believe these will be a gamechanger (assuming Discord doesn't just decide to put some weird limits on it).

Migration

Originally, I wanted to include the migration of Tooga from v13 to v14 along with the verification PR. However, due to a lot of runtime errors that I encountered from my own implementation, along with me being busy for the next few weeks, I decided not to include the v14 codebase in the verification PR.

That being said, this means I do have a version of Tooga that uses discord.js v14 -- this version compiles successfully, although (like I said) there are numerous runtime errors, most likely caused by my misunderstanding of the new types and whatnot introduced in v14. This implementation of Tooga includes the changes from the verification PR (#205), so merging should not be an issue.

@dmansdman @nyapat if one of you guys would like to take on the role of fixing the remaining runtime bugs from my implementation, please let me know here and assign yourself to this issue. I'll send you the source code via Discord.

@ewang2002 ewang2002 added it-bug Issue Type: Bug report it-enhancement Issue Type: Enhancement (new feature or request) c-internal Category: Internal implementation (e.g., library changes) labels Jul 19, 2022
@nyapat
Copy link
Contributor

nyapat commented Jul 24, 2022

since this isn't a priority, waiting for 14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-internal Category: Internal implementation (e.g., library changes) it-bug Issue Type: Bug report it-enhancement Issue Type: Enhancement (new feature or request)
Projects
None yet
Development

No branches or pull requests

2 participants