-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various Tone.LFO issues #1220
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
I'm using
Tone.LFO()
to modulate amplitude of a synth. When I use the sinewave at for example quarter notes, the frequency is correct, but the waveshape is not in sync (the phase is wrong, it looks about 90º off). I've tried setting thephase = 90
but this results in unexpected behaviour (please see the image below from a scope view in Max, looking at the sound coming directly from the browser via Loopback, the right output is a hihat sample usingTone.Loop()
at quarter notes, the left is a synth withTone.LFO()
also at quarter notes). Because I think changing the phase actually doesn't wrap the phase so I lose a part from the waveform (see images below).Phase moved by
phase = 90
:Phase moved by
phase = -90
:When I change the
LFO
to use a squarewave withthis._lfo.set({ type: 'square' });
the phase is actually correct! But the squarewave has another issue, it is not completely silence (so it's not going from0
to1
) resulting in the synth still sounding a bit softly in the middle parts.Using a
sawtooth
LFO the phase is again off, but this time it looks to be off by180º
Is there anything that can be done to fix these phase offsetting issues? It would be great if the phases would be the same for every wavetype that can be selected. And if the squarewave can be silenced in the middle part. Thanks in advance for the help!
The text was updated successfully, but these errors were encountered: