Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed image are not correctly reported with podman #182

Open
florentulve opened this issue Sep 23, 2023 · 6 comments
Open

Installed image are not correctly reported with podman #182

florentulve opened this issue Sep 23, 2023 · 6 comments
Labels
wontfix This will not be worked on

Comments

@florentulve
Copy link

Describe the bug

The wrapper is able to download and installed an image correctly.
However, further exegol install invocation does not report installed image.

After some debugging and step by step execution, i'v found that podman include the registry in the image tag, docker may not do it by default when docker.io registry is involved.

image

Steps To Reproduce

No response

Exegol Wrapper Version

Master branch 

5428a7a665cc386ac0d2d9296eb9ad07166920a2

Host OS

None

Configuration of the concerned container

No response

Execution logs in debug mode

![image](https://github.com/ThePorgs/Exegol/assets/2817358/aee5c1be-5d08-42d2-aed4-e6b4c92a21fa)

Exception

No response

Anything else?

No response

@florentulve florentulve added the bug Something isn't working label Sep 23, 2023
@ShutdownRepo
Copy link
Member

Would you be able to do the change on your end and open a PR?
As it is not our priority to support podman we won't spend time on it for the time being, but if there are pull requests that bring those changes we will be more than happy to review 🫡

@florentulve
Copy link
Author

Ok, that's fair. I've made some other fixes to make things work. I'll open a pr when I will have enough time to to wrap it up.

@ShutdownRepo
Copy link
Member

It'd be awesome! Thank you

@ShutdownRepo ShutdownRepo added wontfix This will not be worked on and removed bug Something isn't working labels Sep 27, 2023
@ShutdownRepo ShutdownRepo changed the title [BUG] Installed image are not correctly reported with podman Installed image are not correctly reported with podman Oct 19, 2023
@xAiluros
Copy link

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

@florentulve
Copy link
Author

florentulve commented Nov 30, 2023

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

@xAiluros , made a small PR with the fixes I have done so far.

@xAiluros
Copy link

xAiluros commented Dec 1, 2023

@florentulve do you happen to have anything you can share w.r.t. the mentioned fixes? Even if just poc or not fully working, it would be appreciated

@xAiluros , made a small PR with the fixes I have done so far.

Thank you! Hope I can try it out soon and will try to see if I can improve anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants