Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated hyperlinks of faq page #4539

Merged
merged 7 commits into from
May 28, 2024
Merged

Fix outdated hyperlinks of faq page #4539

merged 7 commits into from
May 28, 2024

Conversation

M-AminAlizadeh
Copy link
Contributor

@M-AminAlizadeh M-AminAlizadeh commented May 23, 2024 •
edited

Because

This PR made to solve the specific issue that assigned me (#4515) in this repo.

This PR

  • All links in the faq page now working properly without any issues.

Issue

Closes #4515

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4539 May 27, 2024 15:31 Inactive
MaoShizhong
MaoShizhong approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these hrefs! 🚀

@MaoShizhong MaoShizhong merged commit c7e8f9a into TheOdinProject:main May 28, 2024
3 checks passed
@M-AminAlizadeh M-AminAlizadeh deleted the Fix/outdated-hyperlinks-of-faq-page branch May 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: <outdated hyperlinks of faq page>
3 participants
@M-AminAlizadeh @MaoShizhong @KevinMulhern