Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stories in DMs #17

Open
sn3akyb3ar opened this issue Feb 10, 2024 · 5 comments
Open

Stories in DMs #17

sn3akyb3ar opened this issue Feb 10, 2024 · 5 comments

Comments

@sn3akyb3ar
Copy link

I noticed that when you open a story shared with you via Direct Messages, downloader either doesn't download anything, or it downloads one of three things - 1) your own story, 2) text file with your username (I forgot to copy what was in it), 3) the last story you saw (or last one you downloaded? not sure). It works correctly after refreshing the page.

@TheKonka
Copy link
Owner

Please try the latest version(v2.0.2) to see whether the problem still exists.

@sn3akyb3ar
Copy link
Author

sn3akyb3ar commented Feb 22, 2024

@TheKonka

Yep, the problem still persists.

I did some quick testing:

  1. I sent Luna Blaise's story to myself from my second account and opened it from Direct - it was saved without any problems.
  2. Then I asked a friend to DM me any story - addon saved Luna's story again.
  3. Opened some stories from my feed - all saved with no problems.
  4. Opened some stories from different celebrity's pages - and that's where it gets more weird.
    a) if they have only one story or if it's the first story - it still downloads Luna's story. All subsequent stories are downloaded as intended. If I switch to second story and then back to the first one. it's also downloaded as intended lol.
    b) but if I saw some of their stories before and I open their second story - downloader doesn't download neither the opened story nor Luna's (until refreshing or switching to next story and back.)

Tested on Thorium 119 x64, but I'll check on clean Firefox and let you know if it still happens there.

@sn3akyb3ar
Copy link
Author

Strange. Restarted browser and tried again - and even after restart it still downloads Luna's story. Also, this thing happens a lot lately:
image
image

@TheKonka
Copy link
Owner

Thank you for your testing and feedback! I have found the cause.
Sometimes the link has an media id in it, and sometimes it doesn't. In both cases I handle it differently. The problem is more likely to occur when there is no media id.

If I switch to second story and then back to the first one. it's also downloaded as intended

When you back to the first one, the link will have the media id on it and so media can be downloaded normally. That's why it works weird.
I've updated a new version(v2.0.4) to fix this, but it is still under review.
Unfortunately, I'm not able to reproduce the second problem at the moment, I'll keep an eye on it.

@RVC2020
Copy link

RVC2020 commented Feb 28, 2024

I also have the 2nd problem. For me, it started after updating to v2.0.4.
On Firefox 123, it does not always occur. I notice it when I open stories from the homepage. For you Following section

2024-02-28_20-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants