Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unifying apis that require sign flag. #495

Open
LaoLittle opened this issue May 9, 2024 · 0 comments
Open

unifying apis that require sign flag. #495

LaoLittle opened this issue May 9, 2024 · 0 comments

Comments

@LaoLittle
Copy link

LaoLittle commented May 9, 2024

Hi.

When I was using inkwell for code generation, I found that some operations (like div/rem) are divided into two functions
because they require a sign flag to work.

And then I was using shift apis and was trying to figure out where is the build_right_shift_signed function, but there's only one function called build_right_shift which takes an argument to determine whether the operation is sign extended.

Describe the solution you'd like

Make the build_int_signed_op to build_int_op which takes an argument called sign_extend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant