Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIfcWorker.GetNameFromTypeCode always returns <web-ifc-type-unknown> #158

Open
jespa007 opened this issue Mar 9, 2023 · 0 comments
Open

Comments

@jespa007
Copy link
Contributor

jespa007 commented Mar 9, 2023

Hi,

Acording last the last code of web-ifc-three.js when it request GetNameFromTypeCode from IFC/web-workers/workers/WebIfcWorker.ts module, it passes data.args.modelID parameter as is shown in the following code,

export class WebIfcWorker implements WebIfcWorkerAPI {
	
	...
	GetNameFromTypeCode(data: IfcEventData) {
               data.result=this.webIFC.GetNameFromTypeCode(data.args.modelID); // data.args.modelID --> undefined
               this.worker.post(data);
        }
	
	...
	
}

The resulting value of data.args.modelID is undefined because acording last web-ifc implementation now the parameter passed is data.args.type. So the GetNameFromTypeCode body should be modified as it follows,

export class WebIfcWorker implements WebIfcWorkerAPI {
	...
	
	GetNameFromTypeCode(data: IfcEventData) {
             data.result=this.webIFC.GetNameFromTypeCode(data.args.type);  // data.args.type -->  ok
             this.worker.post(data);
       }
	...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant