Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Window decoration (close, minimize, maximize) doesn't show on Linux. #291

Closed
3 tasks done
kyngs opened this issue Jul 6, 2023 · 10 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@kyngs
Copy link
Contributor

kyngs commented Jul 6, 2023

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the frequently asked questions for a solution that fixes this problem, without success.
  • I have checked that I'm using the latest stable version of the app.

What app version are you using?

v4.1.3

What operating system version are you using?

Linux

Expected Behavior

The minimize/maximize/close icons appear.

Actual Behavior

They're not there, I can only close the app by right-clicking its icon on the taskbar. Interestingly, I can still drag the window by clicking the upper part of it.

Screenshots

image

@kyngs kyngs added the bug Something isn't working label Jul 6, 2023
@kyngs
Copy link
Contributor Author

kyngs commented Jul 6, 2023

Just to add, I'm running Arch Linux 6.4.1 with KDE Plasma on Xorg with mesa drivers 23.1.3

@ThaUnknown
Copy link
Owner

this is likely caused by: https://github.com/ThaUnknown/miru/blob/master/src/main/main.js#L135-L139

could u try fucking around with it, like setting it to only true, or smth like that on linux and PR? i dont have a linux machine :)

@ThaUnknown
Copy link
Owner

ah, this doesn't exist on linux. lol.

@kyngs
Copy link
Contributor Author

kyngs commented Jul 7, 2023

I will try some googling and tinkering today and will see whether it works.

@kyngs
Copy link
Contributor Author

kyngs commented Jul 7, 2023

One solution would be to use the native frame, however, that doesn't look quite well.

image

@kyngs
Copy link
Contributor Author

kyngs commented Jul 7, 2023

Well, apparently there's no other way: electron/electron#23665
Gotta love electron!

@kyngs kyngs changed the title [Bug]: Window decoration (close, minimize, maximize) doesn't show. (Maybe Linux/KDE Plasma issue?) [Bug]: Window decoration (close, minimize, maximize) doesn't show on Linux. Jul 7, 2023
@ThaUnknown
Copy link
Owner

try changing the color of the bar to the same dark as the others, but only on linux and PR it, and i'll merge, linux simply has to cope

@kyngs
Copy link
Contributor Author

kyngs commented Jul 7, 2023

try changing the color of the bar to the same dark as the others, but only on linux and PR it, and i'll merge, linux simply has to cope

That unfortunately won't be possible, because Electron does not provide any control over it.
image

@ThaUnknown
Copy link
Owner

oh lawd

@ThaUnknown
Copy link
Owner

so we need a custom title bar just for linux, wooo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants