Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newer version of Textual has broken various dialogs #98

Open
davep opened this issue Mar 27, 2024 · 1 comment
Open

Newer version of Textual has broken various dialogs #98

davep opened this issue Mar 27, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@davep
Copy link
Collaborator

davep commented Mar 27, 2024 •
edited

As of 0.54.0 (possibly earlier, although this isn't the first instance of a related issue being noticed) the layout of the dialogs within Frogmouth are broken:

Screenshot 2024-03-27 at 14 47 26

Note the difference in the width of the delete dialog in the earlier version with an older Textual (top), and Frogmouth on main using Textual 0.54.0.
@davep davep added the bug Something isn't working label Mar 27, 2024
@davep davep mentioned this issue Mar 29, 2024
Closed
@davep
Copy link
Collaborator Author

davep commented Mar 29, 2024

The root cause of this is recorded in Textualize/textual#4360

davep added a commit that referenced this issue Mar 29, 2024
@davep
Revert the Textual version to 0.53.1
e68ba35 
See #98 and Textualize/textual#4360 for more
context. For the moment this commit will undo the change made in respect to
the request made in #94, but we'll have to remember to unpin again as soon
as the Textual issue is resolved.
@davep davep mentioned this issue Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davep