Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like this source generator is completely non incremental #1345

Open
lsoft opened this issue Jan 13, 2024 · 3 comments
Open

Looks like this source generator is completely non incremental #1345

lsoft opened this issue Jan 13, 2024 · 3 comments
Labels
💗 help wanted Up for grabs. We would accept a PR to help resolve this issue 🚀 optimization

Comments

@lsoft
Copy link

lsoft commented Jan 13, 2024

Looks like this generator (

IncrementalValueProvider<(Compilation, ImmutableArray<EnumDeclarationSyntax>)> compilationAndEnums
) is a part of widespread epidemic with incrementality failure.

You should never have any compilations or symbols in any steps of your incremental pipelines, and especially in output steps.
Those objects are not equatable and not meant to be used this way.

Additional details can be found here zompinc/sync-method-generator#20

@tuscen
Copy link
Member

tuscen commented Jan 13, 2024

@lsoft In our case this is not such a big problem since our source generator is internal and is not used by the wide public. We also don't have much expertise on source generators and how to properly fix this issue. If you have the necessary knowledge and are willing to help I'll be very grateful

@tuscen tuscen added 💗 help wanted Up for grabs. We would accept a PR to help resolve this issue 🚀 optimization labels Jan 13, 2024
@lsoft
Copy link
Author

lsoft commented Jan 13, 2024

@tuscen

If you have the necessary knowledge and are willing to help I'll be very grateful

unfortunate, I'm is in same position, my ISG suffers from this disease too 🫡

We also don't have much expertise on source generators and how to properly fix this issue.

this PR contains a solution which may be useful for us (or may be not). If you decide to fix this, you can TAL to that PR.

@tuscen
Copy link
Member

tuscen commented Jan 13, 2024

@lsoft I'll try to look into that PR when I have free time. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💗 help wanted Up for grabs. We would accept a PR to help resolve this issue 🚀 optimization
Projects
None yet
Development

No branches or pull requests

2 participants