ReservationPoller null error for availability zone

[screechdiesel]

Hello. The ReservationCapacityPoller class attempts to retrieve data elements for each reservation, including:
reservation.getAvailabilityZone()
Which results in a null error for those reservations that are not tied to a specific zone and do not have that data element in the JSON:
"ReservedInstances": [
{
...
"Scope": "Region",
...
}
]

[screechdiesel]

Can also raise a null error in BasicReservationService.java:
Zone zone = Zone.getZone(reservedInstances.getAvailabilityZone());

[shaneknapp]

i'm seeing the same error... ice was working until ~late last week and now it won't even start up. the config hasn't changed.

here's the stack trace i'm seeing:

Message: failed to load reservation prices null
    Line | Method
->>  124 | init                             in com.netflix.ice.basic.BasicReservationService
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
|     97 | <init>                           in com.netflix.ice.processor.ProcessorConfig
|    187 | doCall . . . . . . . . . . . . . in BootStrap$_closure1
|    327 | evaluateEnvironmentSpecificBlock in grails.util.Environment
|    320 | executeForEnvironment . . . . .  in     ''
|    296 | executeForCurrentEnvironment     in     ''
|    266 | run . . . . . . . . . . . . . .  in java.util.concurrent.FutureTask
|   1149 | runWorker                        in java.util.concurrent.ThreadPoolExecutor
|    624 | run . . . . . . . . . . . . . .  in java.util.concurrent.ThreadPoolExecutor$Worker
^    748 | run                              in java.lang.Thread

[NitriKx]

Hi @screechdiesel which version are you using?

This should protect against null availability zone:

ice/src/java/com/netflix/ice/basic/BasicReservationService.java

Lines 165 to 167 in e8afb5b

	// Ignore Region-Wide RIs
	if (offer.getAvailabilityZone() == null)
	continue;