Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Buffer causes item loss in specific condition after saving and reloading by any means #3119

Open
trunksbomb opened this issue Feb 25, 2023 · 2 comments
Labels
bug A problem with the project

Comments

@trunksbomb
Copy link

trunksbomb commented Feb 25, 2023

Important Edit
Original Title: Moving a Storage Buffer as part of a contraption from the Create Mod causes item loss

Describe the bug
Moving an empty, locked Storage Buffer as part of a contraption in the Create Mod causes items in the IN slot to try moving to the OUT slot of the Buffer, but all items except for the last one of the stack are consumed in the process.

It's saving and reloading that causes the issue, regardless of how you do it (with a mod, leaving the chunk so it unloads and coming back, saving and reloading). Do the first 4 steps in the "Steps to Reproduce" then just save and reopen the game and the same bug happens.

Steps to Reproduce
Steps to reproduce the behavior:

  • Place a Storage Buffer on a Create contraption that will cause the Storage Buffer to move with the Contraption. Tested with both a Piston (translational movement) and a Mechanical Bearing (rotational movement).
  • Place at least 1 item of any kind into the Buffer
  • Lock the Buffer by clicking the lock icon in the top right
  • remove all items from the Buffer. It should be locked and empty.
  • Move the Create contraption
  • Place a stack (of any size) of the same locked item into the Buffer
  • Observe as the items try to move from the IN slot to the OUT slot
  • Only the last item of the stack will appear in the OUT slot

Additional observations

  • After moving the contraption, if you place a stack of items into the Buffer and then take the stack back out while they're being consumed, no item remains in the OUT slot of the Buffer. It seems consistent that the only time an item will go to the OUT during this bug is for the last item in the stack.
  • The bug does not occur if there is an item in the OUT slot of the Buffer. If you place items in the IN slot when there is an item in the OUT slot, nothing happens. As soon as the item is removed from the OUT slot, the bug occurs.
  • Returning the contraption to its original position and/or rotation does not fix the bug
  • Single stack items (such as the bow) do not appear to be affected
  • This does not appear to affect Storage Units, possibly because the entire stack is moved at once when placed in?

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information with the version):

  • Minecraft: 1.19.2
  • Mod Loader: Fabric
  • Reborn Core v5.4.0
  • Tech Reborn v5.4.0
  • Create v0.5.0g-796+1.19.2

Logs
No log output is generated by this bug

Additional context
Add any other context about the problem here.

@trunksbomb trunksbomb added the bug A problem with the project label Feb 25, 2023
@trunksbomb
Copy link
Author

trunksbomb commented Feb 25, 2023

Oh, interesting. it doesn't have anything to do with Create specifically, that's just how I discovered it.

After writing the bug report, I wondered if any other mod could cause this.

I have confirmed that using the Cardboard Box from Coxinha Utilities also causes the same bug.

  • Shift Right Click the Cardboard Box onto the Storage Buffer after setting it up (locking, empty) according to steps above
  • The Cardboard Box will replace the Storage Buffer
  • It is not necessary to pick up the Cardboard Box (by breaking it) and placing it down somewhere else, but you can if you want to
  • (Place the Cardboard Box down if you picked it up then) Shift Right Click the cardboard box to remove it from the Storage Buffer
  • Same bug happens

It appears to be a problem with saving and reloading the Storage Buffer, since I believe that's how both Create and Coxinha handle moving Tile Entities.

@trunksbomb
Copy link
Author

Yea, confirmed that just saving and reloading the game with an empty, locked Storage Buffer causes the issue.

@trunksbomb trunksbomb changed the title Moving a Storage Buffer as part of a contraption from the Create Mod causes item loss Storage Buffer causes item loss in specific condition after saving and reloading by any means Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A problem with the project
Projects
None yet
Development

No branches or pull requests

1 participant