Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for basic API calls like ACTION_OPEN_DOCUMENT #3932

Open
NastyFlytrap opened this issue Sep 9, 2023 · 4 comments · May be fixed by #3953
Open

Support for basic API calls like ACTION_OPEN_DOCUMENT #3932

NastyFlytrap opened this issue Sep 9, 2023 · 4 comments · May be fixed by #3953
Assignees
@TranceLove
Labels
Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Issue-Feature A feature request or improvement.

Comments

@NastyFlytrap
Copy link

NastyFlytrap commented Sep 9, 2023 •
edited by VishnuSanal

Is your feature request related to a problem? Please describe.

Im trying to use amaze with keepassDX but according to it, Amaze doesnt support certain functions and calls.

Describe the solution you'd like

For Amaze to support these calls so that i can use it with other applications that rely on those calls

Describe alternatives you've considered

Material files exists, i guess. Amaze is better.

Additional context

I tried asking the keepassDX devs for help and they told me to bug you about this:
Kunzisoft/KeePassDX#1626
@VishnuSanal VishnuSanal added the Issue-Feature A feature request or improvement. label Sep 9, 2023
@VishnuSanal VishnuSanal changed the title Support for basic API calls like ACTION_OPEN_DOCUMENT Support for basic API calls like ACTION_OPEN_DOCUMENT Sep 9, 2023
@TranceLove TranceLove self-assigned this Sep 11, 2023
@TranceLove TranceLove added the Area-FileOperations Related to file operations (e.g. moving, copying, renaming). label Sep 11, 2023
TranceLove added a commit to TranceLove/AmazeFileManager that referenced this issue Sep 11, 2023
@TranceLove
Basic support for OPEN_DOCUMENT intent
957839b 
Allows external programs use Amaze to open files with OPEN_DOCUMENT intent.

Addresses TeamAmaze#3932
@TranceLove
Copy link
Collaborator

TranceLove commented Sep 11, 2023 •
edited

Developer's note:

Support for OPEN_DOCUMENT is not hard - sounds like reusing the ringtone picker logic without saying ringtone stuff already worked. 957839b above already supports opening KeePassDX database files either on internal storage and SD card.

But for CREATE_DOCUMENT intent is another story.

  • Easy answer is to construct a content://com.android.externalstorage.documents URI and let DocumentsUI do the rest. Since we expect end users' device must have DocumentsUI bundled (or else SD card access won't work at all) this shouldn't be difficult
  • if not we'll expect Android will ask us for the OutputStream eventually (as the content:// URI will contain our package ID and we are expected to handle this), and we need to write the logic to construct the OutputStream

@NastyFlytrap
Copy link
Author

Developer's note:

Support for OPEN_DOCUMENT is not hard - sounds like reusing the ringtone picker logic without saying ringtone stuff already worked. 957839b above already supports opening KeePassDX database files either on internal storage and SD card.

But for CREATE_DOCUMENT intent is another story.

* Easy answer is to construct a `content://com.android.externalstorage.documents` URI and let DocumentsUI do the rest. Since we expect end users' device must have DocumentsUI bundled (or else SD card access won't work at all) this shouldn't be difficult

* if not we'll expect Android will ask us for the `OutputStream` eventually (as the `content://` URI will contain our package ID and we are expected to handle this), and we need to write the logic to construct the `OutputStream`

I understand, but i dont have any clue how to write the code for that, im only familiar with basic C# and basic Python

@TranceLove
Copy link
Collaborator

@NastyFlytrap That's ok, will work on it at our side anyway 🙂

@NastyFlytrap
Copy link
Author

@NastyFlytrap That's ok, will work on it at our side anyway 🙂

Thank you for your hard work

TranceLove added a commit to TranceLove/AmazeFileManager that referenced this issue Oct 14, 2023
@TranceLove
ACTION_CREATE_DOCUMENT support
8167e89 
Fixes TeamAmaze#3932
@TranceLove TranceLove linked a pull request Oct 14, 2023 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TranceLove TranceLove

Labels
Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Issue-Feature A feature request or improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OPEN_DOCUMENT and CREATE_DOCUMENT intents support TranceLove/AmazeFileManager
3 participants
@TranceLove @NastyFlytrap @VishnuSanal