Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FTP on admin-lists.js #331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for FTP on admin-lists.js #331

wants to merge 2 commits into from

Conversation

CodeRedDev
Copy link
Contributor

Closes #330

This adds support for fetching adminlists via FTP.

This can be done by adding a source like the following to adminLists in config.json:

"adminLists": [
  {
    "type": "ftp",
    "ftp": {
        "host": "XXX.XX.XXX.XX",
        "port": 12345,
        "user": "username",
        "password": "p@ssw0rd"
    },
    "source": "/SquadGame/ServerConfig/Admins.cfg"
  }
]

@CodeRedDev
Copy link
Contributor Author

As I am pretty new to Node JS and more professional JS projects I'm pretty sure some part of code does not follow best practices. Please give me some advice if you find some bad code here :)

Apart from code this seems to work pretty fine on my own Squad server.

@CodeRedDev
Copy link
Contributor Author

Just realized that to complete this issue I would have to add the info above to the ReadMe.

Would appreciate to first have a code review before adding info to ReadMe that doesn't fit the final solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch adminLists via FTP
1 participant
@CodeRedDev