Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issues in the definition of programs.dataset,tensorflow_dl_models/official/mnist/dataset.py #191

Open
DLPerf opened this issue Aug 20, 2021 · 0 comments

Comments

@DLPerf
Copy link

DLPerf commented Aug 20, 2021

Hello,I found some performance issues.
The first one is in the definition of dataset ,tensorflow_dl_models/official/mnist/dataset.py,
tf.data.FixedLengthRecordDataset(images_file, 28 * 28, header_bytes=16).map was called without num_parallel_calls.
I think it will increase the efficiency of your program if you add this.

The same issues also exist in tf.data.FixedLengthRecordDataset(
labels_file, 1, header_bytes=8).map
,
.map(decode_csv)),
dataset = dataset.map(decode),
dataset = dataset.map(decode)
and dataset = dataset.map(_parse_line)

Here is the documemtation of tensorflow to support this thing.

The socond one is in thedefinition of Eval,tensorflow_dl_models/research/street/python/vgsl_model.py.
sess = tf.Session('') was repeatedly called and was not closed.
I think it will increase the efficiency and avoid out of memory if you close this session after using it.

The same issues also exist in sess = tf.Session()

Here are two files to support this issue,support1 and support2

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant