fix(angular-query-experimental): allow returning undefined in initialData function #7351
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4cfa6ff:
|
|
It seems like the styling changes were done automatically on commit by lint-staged. Let me know if you think something in my set up is wrong and it shouldn't have happened. |
ShacharHarshuv
force-pushed
the
initialData-should-allow-undefined
branch
from
fc00927
to
f579962
Compare
|
I fixed the prettier issue |
ShacharHarshuv
force-pushed
the
initialData-should-allow-undefined
branch
from
f579962
to
97f4a62
Compare
|
@TkDodo Done! |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4cfa6ff. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
@TkDodo @arnoud-dv Can this be merged? |
ShacharHarshuv
force-pushed
the
initialData-should-allow-undefined
branch
from
eba777f
to
4cfa6ff
Compare
|
Looks good to me, @TkDodo agree if we merge this? |
Fix incorrect types that disallowed that. This is necessary because the initialData function can typically read cache synchronously and need to be able to signal to the query if there is a cache miss and an actual fetch needs to be deployed.
Fixes #7341
No breaking changes, any code that worked before should work now as well.