Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insert value behaviour #697

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Balastrong
Copy link
Contributor

This PR closes #696

As mentioned on Discord, this should be the expected behavior of "inserting a value into an array".

Copy link

nx-cloud bot commented May 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af4d5e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@crutchcorn
Copy link
Member

I think this is correct. Can we add in a new replaceFieldValue to act like the old insertFieldValue API? I'm more than happy to merge if we're able to add that + some minor tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insertFieldValue replaces item instead of adding a new one and shift existing items
2 participants