New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array fields do not run onChange validation #662
Labels
Comments
Never mind, this is exactly what |
@crutchcorn I created a PR that should fix this issue, if you want to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When calling the array helper method
pushValue
orremoveValue
, noonChange
validation is triggered on the array field that called the helper methods.The validation is only run, when setting the
isTouched
state manually and calling thefield.validate("change")
method manually.Your minimal, reproducible example
https://stackblitz.com/edit/tanstack-form-8sihxk?file=src%2Findex.tsx
Steps to reproduce
Expected behavior
As a user, I would expect every method that results in a mutation to validate for the "change" event, but that does not happen for the array helper methods.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
TanStack Form adapter
react-form
TanStack Form version
v0.19.0
TypeScript version
v5.4.3
Additional context
This is not part of this bug, but I would also think working with the array helper methods would be easier if they would also allow for setting the touched state when using the FieldApi.
The text was updated successfully, but these errors were encountered: