-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't panic, return error #103
Comments
Note that you can mix thiserror and eyre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the following error is not user-friendly.
I found at least two not-good points of error handling of this repository.
Version.parse()
panics. This should return an error if the parse failed.expect()
. Here, we should receive errors and show them to users.I recommend you to use eyre and color-eyre. See https://github.com/yaahc/color-eyre/blob/master/examples/usage.rs and try to run.
(eyre is a fork of anyhow and I think eyre suits CLI programs because it has additional features like suggestion.)
The text was updated successfully, but these errors were encountered: