New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the updated `select_credentials` test vector #512

Open

jiyoontbd opened this issue May 3, 2024 · 0 comments

Contributor

jiyoontbd commented May 3, 2024 •

edited

Currently, consuming select_credentials.json test vectors in this repo results in failure for the test vectors with these descriptions:

select credentials for presentation, multiple input descriptors, not all of them are satisfied
select credentials for presentation, using array filter

We should consider these two things:

Is the test vector asserting the correct output?
If answer to 1 is yes, is the selectCredentials() implementation making incorrect assumptions?
Overall, are we interpreting the PEX spec correctly?

The possible outcomes of this issue is that we address the failures by either changing the implementation or changing the test vector.

The text was updated successfully, but these errors were encountered:

jiyoontbd changed the title ~~Use the new select_credentials_go test vector~~ Use the new select_credentials test vector

jiyoontbd changed the title ~~Use the new select_credentials test vector~~ Use the updated select_credentials test vector

jiyoontbd mentioned this issue

bumping submodule commit #521

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment