generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Status List Credential API #487
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @thehenrytsai
create
Design: from status list lifecycle management and dev experience standpoint, I doubt one would frequently create a status initially with credentials already revoked. It would be more useful if:
ie. Revoke a VC from an existing status list. This would be the main line scenario of status list usage. I'd suggest to have
create()
create an empty list, and perhapsrevoke()
that does the bit operation on an existing list.ie. Reactivate a suspension of VC.
(To be clear, this one is completely an optional ask, please ignore unless super low hanging fruit)
validateCredentialInStatusList
Design: this is probably bad naming of the method, or bad ChatGPT documentation generation 😆 :
When the value is 1 in the given index position, it does not mean the credential is "in the status list" as the method name and documentation states, it can be a valid index even if the value is 0. So we ought to rename the method to something like isCredentialRevoked(), though I generally prefer having method checking for the happy case, in which case something like validateCredentialStatus() and flip the logic.
The text was updated successfully, but these errors were encountered: