Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwn unit tests fail intermittently once PR is merged into main #477

Open
jiyoontbd opened this issue Apr 2, 2024 · 3 comments
Open

dwn unit tests fail intermittently once PR is merged into main #477

jiyoontbd opened this issue Apr 2, 2024 · 3 comments

Comments

@jiyoontbd
Copy link
Contributor

jiyoontbd commented Apr 2, 2024 •
edited
Loading

happened when #476 was merged. it was re-run and passed successfully, which points to the failing test being affected by race condition. i could find no record of the transient ci failure in the actions tab :(
@LiranCohen
Copy link
Member

Thanks @jiyoontbd!! I'll try to reproduce.

@jiyoontbd
Copy link
Contributor Author

@LiranCohen ah! i found the ci run where it failed. i just had to click 5 levels deep to find it

https://github.com/TBD54566975/web5-js/actions/runs/8516766403/job/23326301339

@jiyoontbd
Copy link
Contributor Author

jiyoontbd commented Apr 3, 2024 •
edited
Loading

maybe related - node-sdk-reports also fails intermittently https://github.com/TBD54566975/web5-js/actions/runs/8541288382/job/23400248626 and https://github.com/TBD54566975/web5-js/actions/runs/8485265479/job/23249737612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LiranCohen @jiyoontbd