Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled products do not disappear from a cart #15933

Open
coldic3 opened this issue Feb 29, 2024 · 1 comment
Open

Disabled products do not disappear from a cart #15933

coldic3 opened this issue Feb 29, 2024 · 1 comment
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.

Comments

@coldic3
Copy link
Contributor

coldic3 commented Feb 29, 2024

Sylius version affected: 1.12 (but all versions I guess)

Description
When we have a cart with products and some or all of them have been disabled meanwhile, these products are still visible in the cart and we can continue with all steps in the checkout except the "complete" step. It means we cannot place an order with disabled products. However, the validation error doesn't point out which products are disabled. Moreover, clicking "Update cart" doesn't remove these products from the cart.

Steps to reproduce

Given the store operates on a single channel in "United States"
And the store has a product "PHP T-Shirt"
And the store has a product "PHP Mug"
When I add product "PHP T-Shirt" to the cart
And I add product "PHP Mug" to the cart
And the "PHP T-Shirt" products has been disabled
And I update my cart
Then I should be notified that this product "PHP T-Shirt" is no longer available
Or I should see cart total quantity is 1

Possible Solution
Remove disabled products on cart update or validate the cart for enabled products only.

@crydotsnake
Copy link
Contributor

Can reproduce it too.

@NoResponseMate NoResponseMate added UX Issues and PRs aimed at improving User eXperience. Shop ShopBundle related issues and PRs. Bug Confirmed bugs or bugfixes. labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

No branches or pull requests

3 participants