-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metamask's privacy mode #172
Comments
Ok not as simple as I thought, the metamask developers might have forgotten to implement this for connections from other browser extensions. Thankfully the privacy option is opt-in for now. We should file an issue and hope it gets fixed before it turns opt-out. |
Submitted an issue here MetaMask/metamask-extension#5950 |
Also discussed here: MetaMask/extension-provider#3 |
Temporary workaround issue: #200 |
Maybe better workaround MetaMask/metamask-extension#5950 (comment) |
This article describes it pretty well https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8
it talks about it from the perspective of websites, but I think it applies to us too.
Doesn't seem like major changes are needed (hopefully just a few lines) but either way, we need to fix this before the deadline.
The text was updated successfully, but these errors were encountered: