-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVEngine.skip_step is not used #139
Comments
Thanks for catching this @kanderso-nrel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PVEngine creates a mask indicating values that need not be considered in the calculation:
pvfactors/pvfactors/engine.py
Lines 170 to 175 in 21d4865
However, that mask is not actually used anywhere today. It used to be, but it looks like it stopped being used in #84 during the switch from iterative to vectorized code.
I think the underlying concept may still be useful even in the current vectorized approach, so I think it's probably worth seeing if we can start using it again somehow, otherwise it should just be deleted IMHO.
The text was updated successfully, but these errors were encountered: