Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nice error message when 'composer.json' cannot be loaded #1588

Open
kaste opened this issue Apr 5, 2019 · 3 comments
Open

Nice error message when 'composer.json' cannot be loaded #1588

kaste opened this issue Apr 5, 2019 · 3 comments
Labels
actionable good first issue

Comments

@kaste
Copy link
Contributor

kaste commented Apr 5, 2019 •
edited

Solved for NodeLinter in #1447, problem for Composer is that we don't speak php here.

Closes SublimeLinter/SublimeLinter-phpcs#44
@AndrewMast
Copy link
Contributor

I'm confused about you mentioning php... The re-writing of the ComposerLinter shouldn't require knowledge of php since it is a json file?

@kaste
Copy link
Contributor Author

kaste commented Apr 5, 2019

Any refactoring is risky if we can't do some at least some manual testing. 🤷‍♀️

@AndrewMast
Copy link
Contributor

Ah. I work in PHP a lot so I might be able to do some work on the ComposerLinter in a week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable good first issue
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaste @AndrewMast