[WIP] Which executable? #1363
Closed
[WIP] Which executable? #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me. Anything in particular I should test? |
|
@kaste Wanna merge this? |
|
Nope or not sure. Don't think it adds enough value right now. I have added several other commits on top of it on my computer. I want to get a clearer picture of the direction the API should go. |
|
👍 |
kaste
force-pushed
the
which-executable
branch
from
168f3d3
to
8382485
Compare
BREAKING: make fn `(str) -> Optional[List[str]]`
`context_sensitive_executable_path` had a polymorphic signature in that
it also allowed the full `cmd` to be passed in. However all
implementations then only extracted `cmd[0]` and acted upon that.
Esp. for the new `which_executable` we want a simpler signature, so that
the user can just call e.g. `self.which_executable('mypy')`. We, of
course, could transform this internally to `['mypy']`, pass it down,
and transform it back to `'mypy'` in every `csep` implementation.
kaste
force-pushed
the
which-executable
branch
from
d0e2fdf
to
9d3e9e7
Compare
|
Bye 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose
get_executable() -> Optional[List[str]]Factor
linter.which_executable(str) -> Optional[List[str]]Change signature of
context_sensitive_executable_pathas proposed in #1362Fixes #1335
Fixes #1362