Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube preview not working #30

Closed
xuko opened this issue Jan 27, 2023 · 3 comments · May be fixed by Sub6Resources/flutter_html#1421
Closed

Youtube preview not working #30

xuko opened this issue Jan 27, 2023 · 3 comments · May be fixed by Sub6Resources/flutter_html#1421

Comments

@xuko
Copy link

xuko commented Jan 27, 2023

Dont load preview on youtube channel feeds
Screenshot_2023-01-27-08-34-02-16_e5bd6a9703d9bd478acaa5bf6f6c6be2
@DocMarty84
Copy link
Owner

Hello,
Yes, I'm aware of this... No solution at the moment :(

DocMarty84 added a commit to DocMarty84/flutter_html that referenced this issue May 12, 2024
@DocMarty84
fix: enable JavaScript in iframe
be92255 
When an iframe contains the `sandbox` attribute, its value must be
exactly `allow-scripts` in order to enable JavaScript. However, in many
cases the attribute has more than one value. Here is an example:[^1]

```
sandbox="allow-scripts allow-same-origin allow-popups allow-popups-to-escape-sandbox"
```

We make the condition more flexible by using `contains`.

Fixes DocMarty84/miniflutt#30

[^1]: https://github.com/miniflux/v2/blob/3388f8e376632da49be8d8785422962ba83a8518/internal/reader/sanitizer/sanitizer.go#L238
@DocMarty84 DocMarty84 mentioned this issue May 12, 2024
Open
@DocMarty84
Copy link
Owner

Alright, I found the issue. I'll deploy a fix soon.

@DocMarty84
Copy link
Owner

Fixed from v1.13.0 which is built with the fix Sub6Resources/flutter_html#1421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable JavaScript in iframe DocMarty84/flutter_html
2 participants
@DocMarty84 @xuko