Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Task CE natively #761

Open
jkone27 opened this issue Mar 15, 2022 · 2 comments
Open

Support Task CE natively #761

jkone27 opened this issue Mar 15, 2022 · 2 comments

Comments

@jkone27
Copy link

jkone27 commented Mar 15, 2022

maybe also providing support for Task or IcedTask instead of Async could improve suave performance quite a bit over the original async.

since latest F# we have native task CE support, and now also this was recently published/developed..

https://github.com/TheAngryByrd/IcedTasks

@njlr
Copy link
Contributor

njlr commented Jan 14, 2023

I could imagine a type like this working well:

[<Struct>]
type Response<'t> =
  | Value of value : 't
  | Sync of sync : (unit -> 't)
  | Async of async : Async<'t>
  | ColdTask of coldTask : (unit -> Task<'t>)
  | CancellableTask of cancellableTask : (CancellationToken -> Task<'t>)

It would be a breaking change though

@ademar
Copy link
Member

ademar commented Jan 14, 2023

Agreed I think is about time to bring Task to Suave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants