Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image colours being inverted #145

Open
Oqwert opened this issue Sep 23, 2020 · 7 comments
Open

Image colours being inverted #145

Oqwert opened this issue Sep 23, 2020 · 7 comments
Labels

Comments

@Oqwert
Copy link

Oqwert commented Sep 23, 2020

The colours on some seemingly random images are being inverted only when this style is active on Wikipedia. It seems to happen a lot on flags but also happens on pictures such as this one;
https://en.wikipedia.org/wiki/Indian_National_Army#/media/File:Gandhi_and_Subhas_Bose.jpg

In case you don't see the same things I do, I took a screenshot of what I see

Inspect element:

I am using the latest version of this theme on Stylus on Chrome (Windows 10) and haven't changed anything in the style itself.

@the-j0k3r
Copy link
Member

@Oqwert thx for report, but I also would like a link to a page that has the affected flags you mentioned.

Thx

@Oqwert
Copy link
Author

Oqwert commented Sep 23, 2020

There are many across Wikipedia, but this is a good collection of them

https://en.wikipedia.org/wiki/Timeline_of_national_flags

Among the inverted ones are the 1508 flag of Armenia, 1796 flag of Azerbaijan, 1536 flag of Denmark, 1697 and 1992 flags of Brazil, 1870 flag of Japan and others. In most if not all cases only the miniaturized versions appear inverted, going back to normal when you click on them and the details are shown.

@the-j0k3r
Copy link
Member

Thx, fix incoming sometime today.

@the-j0k3r
Copy link
Member

Real life got in the way, good news though, I started working on #146 its mostly done so Ill push the fixes soon as I have a few more minutes to spare.

Sorry for the delay.

the-j0k3r added a commit that referenced this issue Sep 25, 2020
* update devdeps (the-j0k3r)
* general fixes closes #145 closes #146 (the-j0k3r)
@Oqwert
Copy link
Author

Oqwert commented Sep 26, 2020

Found some more

https://en.wikipedia.org/wiki/Talk:Sino-Soviet_split#/media/File:Featured_article_star_-_cross.svg

https://en.wikipedia.org/wiki/Timeline_of_national_flags#Asia
(Iran, 1796)

https://en.wikipedia.org/wiki/Talk:Timeline_of_national_flags#/media/File:Clipboard.svg

https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Wikipedia#Former_featured_articles
(Icons of former featured article, featured lists, good articles, former good articles, "did you know?")

https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Wikipedia#Assessment_of_articles
(Featured list and good article icons)

https://en.wikipedia.org/wiki/File:Information.svg (also the miniaturized version, as seen at https://en.wikipedia.org/wiki/Wikipedia_talk:Featured_articles#%22Brilliant_prose%22_listed_at_Redirects_for_discussion)

https://en.wikipedia.org/wiki/File:Stock_post_message.svg

Edit 1:
https://en.wikipedia.org/wiki/Trotskyism
("Communism portal" and "Politics portal" icons)

Edit 2:
https://en.wikipedia.org/wiki/Human_Development_Index#2018_Human_Development_Index_(2019_report)
(Flag of Switzerland)

Edit 3:
https://en.wikipedia.org/wiki/Switzerland#Cantons
(Canton flags)

Edit 4:
https://en.wikipedia.org/wiki/History_of_Afghanistan
("Book" icon on the infobox in the right side of the screen)

Edit 5: https://en.wikipedia.org/wiki/United_States_Army
(All flags on the Infobox->Commanders section)

and

https://en.wikipedia.org/wiki/Mike_Gravel
(Infobox->Military service->United States Army flag)

Edit 6: https://en.wikipedia.org/wiki/July_2020_Armenian%E2%80%93Azerbaijani_clashes#International
(Vatican flag)

Edit 7: https://en.wikipedia.org/wiki/Wikipedia:Administrator_intervention_against_vandalism
(Icon where it says "You can subscribe to a web feed of this page in either RSS or Atom format.")

Edit 8: https://en.wikipedia.org/wiki/Adam_Smith
(Infobox->Part of a series on Capitalism->"Business portal" icon)

Edit 9: https://en.wikipedia.org/wiki/Talk:Wikipedia
(Where it says article milestones, Article_Collaboration_and_Improvement_Drive.svg.png)

Edit 10: https://en.wikipedia.org/wiki/Tau
(Bottom of infobox, Book and Commons logos)

Edit 11: https://en.wikipedia.org/wiki/U.S._state#States_of_the_United_States
(Flag of Rhode Island)

Edit 12: https://en.wikipedia.org/wiki/Flag_of_Mississippi#Call_for_public_submissions
(Left side, images of the five finalists)

Edit 13: https://en.wikipedia.org/wiki/Wikipedia:Reliable_sources/Perennial_sources#Legend
(No consensus icon)

Edit 14: https://en.wikipedia.org/wiki/Wikipedia:Drop_the_stick_and_back_slowly_away_from_the_horse_carcass
(Top right sign, Ambox_humor.svg.png)

Edit 15: https://en.wikipedia.org/wiki/Talk:Homeopathy#GA_Review
(Icons, Symbol_wait.svg.png, Crystal_Clear_app_clock-orange.svg.png, Symbol_support_vote.svg.png)

Edit 16: https://ru.wikipedia.org/wiki/%D0%92%D1%82%D0%BE%D1%80%D0%B0%D1%8F_%D0%BC%D0%B8%D1%80%D0%BE%D0%B2%D0%B0%D1%8F_%D0%B2%D0%BE%D0%B9%D0%BD%D0%B0
(Infobox->Flags of Denmark, Norway, San Marino)

Edit 17: https://en.wikipedia.org/wiki/Comic_Sans
(Template at the top->Text_document_with_red_question_mark.svg.png)

@the-j0k3r
Copy link
Member

the-j0k3r commented Sep 26, 2020

Found some more

This will have to wait, no time due to real life atm and already have a backlog of bugs fixes across several repos to handle first before coming to this.

Ive reopened the issue so I dont forget.

Meanwhile, PR's welcome.

@the-j0k3r the-j0k3r reopened this Sep 26, 2020
@the-j0k3r
Copy link
Member

Please read #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants