Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Native Dark Mode #1275

Closed
peaceiris opened this issue Dec 8, 2020 · 19 comments
Closed

GitHub Native Dark Mode #1275

peaceiris opened this issue Dec 8, 2020 · 19 comments

Comments

@peaceiris
Copy link

Today, we got the GitHub native dark theme.

This stylus GitHub Dark theme has helped me always. I want to leave my big thanks for this awesome project!

Screen Shot 2020-12-09 at 3 03 20

@peaceiris peaceiris changed the title GitHub Dark Mode GitHub Native Dark Mode Dec 8, 2020
@peaceiris
Copy link
Author

Did you have a collaboration with the GitHub team? Just curious.

@the-j0k3r
Copy link
Member

Nothing to do with us.

@the-j0k3r
Copy link
Member

Gists is are unstyled by dark mode.

@unigazer
Copy link

unigazer commented Dec 8, 2020

@the-j0k3r Lots of components are unstyled yet, but that's why it's still in "Beta".

@erkinalp
Copy link

erkinalp commented Dec 8, 2020

Official dark theme is more like Solarized Dark, so, we would still like to have a deep dark update for this.

@friendlyanon
Copy link
Contributor

Personally I dislike the native dark theme, because it's too blue (12,17,23) compared to this theme's neutral black (24,24,24).

@silverwind silverwind pinned this issue Dec 8, 2020
@silverwind
Copy link
Member

Just pinning this for visibilty. I guess we will keep maintaining this style for at least a while because I personally can't stand GH's dark mode 😉

@auscompgeek
Copy link
Contributor

Perhaps it'd be worth mentioning the native dark theme in the readme as well?

@rEnr3n
Copy link

rEnr3n commented Dec 9, 2020

I hope you continue maintining this for those who choose not to have an account here.

@damianh
Copy link

damianh commented Dec 9, 2020

Definitely don't like their dark blue theme. This one is much nicer.

@Geobert
Copy link

Geobert commented Dec 9, 2020

Moreover, we can choose the syntax highlighting color with this theme :)

@the-j0k3r
Copy link
Member

Unsubcribed

@mxdanger
Copy link

Will this theme eventually just act as a custom GitHub theme that only changes GitHub's 600+ CSS variables? This entire theme can now just be a few hundred lines of variables defined in one :root instead of the current 33,900 lines of CSS.

@silverwind
Copy link
Member

silverwind commented Dec 18, 2020

Not if we want to keep support for the other sites like docs,gist,status.github.com etc. and the numerous extensions that still lack a dark mode.

@the-j0k3r
Copy link
Member

the-j0k3r commented Dec 19, 2020

Actually you can remove 90% of the generated CSS by simply replacing the CSS vars assignments and instead of colors for the OTHER site assign them CSS vars in generator not colors... I know for a fact that works I done the same this style does in less than 5K lines all in (only status isnt supported), however not using the generator used here.

Would make this style sane again though, but it was easier for me to do it from scratch else the syntax themes work is not possible to do as this style currently is.

As for the GH 600 vars, is a design choice GH took,, 2/3 only have different var names the colors remain the same.

5K lines all sites except GH status instead of 50K plus thats 95% trim.

@silverwind
Copy link
Member

I'm not going to put any more time into such ventures. It works as-is and if GH decides to variablify their other sites, it will automatically adapt.

@synthead
Copy link

synthead commented Feb 5, 2021

I love the GitHub-Dark custom CSS because it does so much more than just a "dark theme." I love being able to have my console font in code blocks with a color scheme of my choice, for example. Please keep this project going; I love it!

@ThiefMaster
Copy link

I think this theme is still superior to the native dark mode, especially the background!

@zoomlogo
Copy link

Well github just added the new Dark Dimmed. The background looks better than the other dark version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests