Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQMIGRATE: jQuery.type is deprecated #189

Open
ebwaked opened this issue Feb 16, 2022 · 4 comments
Open

JQMIGRATE: jQuery.type is deprecated #189

ebwaked opened this issue Feb 16, 2022 · 4 comments

Comments

@ebwaked
Copy link

ebwaked commented Feb 16, 2022

`// Set the jBox type

    jQuery.type(type) == 'string' && (this.type = type);`

jQuery.migrate-3.3.2 throws this warning for line 198 in jbox.all.js v 3.5

I am not sure how to fix this or else I would do a PR.

@J-Brk
Copy link

J-Brk commented Jun 16, 2022

It's just a little check that makes sure the passed type is a string and only set's it's internal type to it; if it is.

@J-Brk
Copy link

J-Brk commented Jun 16, 2022

jQuery.type(type) == 'string' && (this.type = type);

@ebwaked
Copy link
Author

ebwaked commented Jun 16, 2022

@J-Brk i would have thought that would have worked. I made the change in my file but instead of using jbox.all.min.js I used jBox.js with the new change but got this error.

image

@StephanWagner
Copy link
Owner

Just commented on the pull request: You have to make the changes in the src files (src/js/jBox.js) and then build the dist files with npm install && npm run build from the root folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants