-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling StelAudioMgr at runtime #3775
base: master
Are you sure you want to change the base?
Conversation
- command line option - config.ini option SUG documented
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, what about video support? I guess one config option to suppress both - audio and video support will be better…
I wonder what piece of hardware or Linux subsystem one has to remove/disable to accidentally not being able to show a (silent) video. No graphics card? No screen? And you are running the rest of Stellarium successfully? As commented, I have not yet looked into the case of disabling sound output for videos with sound. Can do that only on the other PC. |
Well… log in #3725 has info about missing gstreamer’s plugin by the fact and gstreamer is not our direct dependency. OK, you’re suppressed audio playback and missing gstreamer’s parts for audio, but Qt using gstreamer for audio channels in video also… |
I hope all videos will be silent… |
Please do not merge yet!
|
gstreamer is some Qt dependency. I assume it gets called on creating a |
Someone can test this now on a sound-less PC or VM. How does it behave attempting to play videos with sound? |
- no AudioMgr and VideoMgr message when media support is disabled - no AudioMgr message when audio is switched off by runtime option
Now I just need confirmation about whether the actual changes work on a (deliberately) crippled Linux system. Videos play silently on Windows, but i don't remove my audio drivers for testing. I also did not test Qt5, sorry to be short in time. |
You can just disable a device in the Device Manager. |
I get the following errors when building on a Windows VM (MSVC++ 17.9.34728.123;
|
This may not circumvent problems with missing hardware, just make sure no sound emits the speakers.
Description
We had a complaint (#3725) that Stellarium takes some extra (unspecified) time to initialize on a system without sound hardware (or disabled). While sound hardware has been generally available on consumer systems of the past 25 years, there may be circumstances, e.g. on Virtual Machines. This branch brings in yet another configuration option to avoid initialisation. The simple alternative is to build Stellarium from source without media support.
Fixes # 3725
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Running scripts/test/audiotest.ssc. When audio system is disabled, observe text output.
I have not yet tested videos with sound output! And I cannot test a physical system without sound hardware.
Test Configuration:
Checklist: