Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On click sky surface brightness value #3668

Open
Krukarius opened this issue Mar 14, 2024 · 6 comments
Open

On click sky surface brightness value #3668

Krukarius opened this issue Mar 14, 2024 · 6 comments
Labels
wishlist Long-term ideas

Comments

@Krukarius
Copy link

Is your feature request related to a problem? Please describe.

When we click on any star or the Sun, we have its visual brightness in magnitude.
Noticed, that this magnitude is computed even if the Sun goes below the horizon. At a solar depression of about 2 degrees, the magnitude value starts to increase rapidly despite the airmass extinction, which I don't understand why. Later it disappears completely. My problem is a lack of knowledge about the twilight brightness at any stage of twilight.

Describe the solution you'd like
We have nothing shown when clicking on any part of the sky. I am wondering about the option of displaying the sky surface brightness at the given time of the day considering the standard atmosphere and its brightness against the:

  • angular distance to the Sun
  • position of the Sun (or other source of light - Moon) above and below the horizon
  • apparent brightness of the light source (Moon, eclipsed Sun or Sun)

Describe alternatives you've considered
There is no other alternative. I am looking for a decent formula for computing it

Additional context
I could map the sky surface brightness value based upon computations such as these.

@gzotti
Copy link
Member

gzotti commented Mar 14, 2024

We stop extinction computations near -2° because (1) the model does not deliver them (see Fig. 19.6 in the User Guide) but (2) this is usually irrelevant, given real horizon cover for observers on the ground.

This has been suggested before (#1404). "Clicking somewhere in the sky" will usually select the nearest star, though.
Meanwhile we have 2 skylight models. Preetham+Schaefer, and ShowMySky. There are notable differences.

@gzotti gzotti added the wishlist Long-term ideas label Mar 14, 2024
Copy link

Hello @Krukarius!

Thank you for this suggestion.

@Krukarius
Copy link
Author

Krukarius commented Mar 14, 2024 via email

@gzotti
Copy link
Member

gzotti commented Mar 14, 2024

@10110111 ?
For the older skylight model I think some value can be produced without too much trouble. But I still did not find time to check the numbers. In #1404 somebody seems to have implemented a solution in his private fork.
Meanwhile we should compare the numbers between both models and against some scientific papers, and thereby find why some "magic scaling values" must be different.

@Krukarius
Copy link
Author

This code says only a little to me to be fair. I would rather see these formulas standalone in some publications if possible.

@10110111
Copy link
Contributor

In #1404 somebody seems to have implemented a solution in his private fork.

The solution seems to only be concerned with light pollution, not any other sources of skylight.

As for ShowMySky, it must be noted that it doesn't simulate airglow, instead doing some hacks similar to those in the Preetham model code.

I would rather see these formulas standalone in some publications if possible.

It's not trivial, because the actual formulas used in the ShowMySky model are those required for simulation (the results being cached in textures). Some references to the paper used as the base for the implementation can be seen here. The input for these formulas though is variable, and it's different from the atmosphere parameters used in the paper.

Finally, yes it's possible to implement computation of luminance of a given direction in the sky, just as it's currently done for the luminance of zenith to enable computation of exposure. But it needs someone capable of coding to find some free time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Long-term ideas
Projects
None yet
Development

No branches or pull requests

3 participants